Eric Holmes

Hey @dbp. > I first tried clicking the launch button on the readme, which successfully created a cluster w/ cloudformation, but I was unable to log in / do anything...

> Just to clarify - if I set GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET on the empire ECS task, then I should enter in my github username for the email and github password...

Thanks for pointing out [distribution/reference](https://github.com/docker/docker/blob/3d13fddd2bc4d679f0eaa68b0be877e5a816ad53/vendor/src/github.com/docker/distribution/reference/reference.go) @protomouse. When we made `image.Image` type, Docker's parsing was all over the place. This looks much nicer!

I have a [branch](https://github.com/remind101/empire/compare/distribution-reference?expand=1) that adds this, but ran into weird issues using [reference.SplitHostname](https://github.com/docker/docker/blob/3d13fddd2bc4d679f0eaa68b0be877e5a816ad53/vendor/src/github.com/docker/distribution/reference/reference.go#L134). Given this test program: ``` go package main import ( "fmt" "github.com/docker/distribution/reference" ) func main() {...

Looking at the [test cases](https://github.com/docker/distribution/blob/master/reference/reference_test.go#L268-L297) for reference.SplitHostname, it seems like it's missing some obvious cases. For example, this passes: ``` go { input: "test_com/foo", hostname: "", name: "test_com/foo", }, ```...

So, turns out it's a legitimate bug in distribution/reference: https://github.com/docker/distribution/pull/963/files/b07d759241defb2f345e95ed04bfdeb8ac010ab2#r66186285

Hi @psinghsp. This error can also be returned when you're trying to pull a private image, but the docker client isn't authenticated. Can you verify that you've provided Empire with...

Awesome! :+1: on a `--scheduler` flag. Yeah, we built the ECS implementation of the scheduler with being able to remove the ELB/Route53 aspect easily so this should be fine.

So, I think we actually wouldn't lose authentication if we decided to do this. We can still github oauth users that come in through the slack commands and do the...

Might require a separate table that stores a `slack user id` -> `empire access token` mapping, but I'm pretty sure we can reuse all of the authorization middleware that we...