coq-serapi icon indicating copy to clipboard operation
coq-serapi copied to clipboard

[PATCH] Compilation with yojson >= 2.2

Open SnarkBoojum opened this issue 1 year ago • 3 comments
trafficstars

Compiling coq-serapi with yojson >= 2.2 means running find serlib -type f |xargs sed -i -e "s/Result.result/Result.t/g" ; I just fixed the issue in Debian.

SnarkBoojum avatar Jun 18 '24 08:06 SnarkBoojum

Hi @SnarkBoojum , I think this is fixed in master, sorry for the trouble.

ejgallego avatar Jun 18 '24 09:06 ejgallego

Will close the issue when we release the 0.20 version, so we can check.

ejgallego avatar Jun 18 '24 09:06 ejgallego

By the way, the problem here is not due to yojson, but to ppx_deriving dropping the dependency on result.

So the right fix is to have serapi now depend on the result OCaml package directly. Before we dependeded on it explicitly.

ejgallego avatar Jun 18 '24 09:06 ejgallego

This should have been fixed in 0.20.0 , please re-open if some more problems arise.

ejgallego avatar Sep 08 '24 15:09 ejgallego