coq-serapi icon indicating copy to clipboard operation
coq-serapi copied to clipboard

!pinned flag should not be used in opam package for releases

Open palmskog opened this issue 5 years ago • 2 comments
trafficstars

The !pinned flag is currently used in the version-tracked opam package definition (coq-serapi.opam).

However, this flag seemingly causes CI failures in the upstream opam repository, so it should never be part of opam package definitions for released versions of SerAPI (that are submitted to this opam repo). This should be accomplished with release automation, to avoid having to manual edit the opam file.

Some more background: ocaml/opam-repository#16564

palmskog avatar Jun 02 '20 14:06 palmskog

Thanks for the report @palmskog , note the comment of @kit-ty-kate here too: https://github.com/ocaml/opam-repository/pull/15850#discussion_r380142221

Apparently opam does not support !pinned (but does pinned): [ERROR] undefined filter variable in dependencies of coq-serapi.8.11.0+0.11.0: pinned

It is a bit unclear to me how to best solve this, ideally we would not have to add some extra release step to the current standard dune-release workflow.

ejgallego avatar Jun 03 '20 18:06 ejgallego

The error seems to have evolved in the latest release, we now just get Coq not installed in OPAM's CI due to the package being pinned? https://github.com/ocaml/opam-repository/pull/17070#issuecomment-681732257

ejgallego avatar Aug 27 '20 14:08 ejgallego