ginga icon indicating copy to clipboard operation
ginga copied to clipboard

Published 20 hours ago • verified publisher icon ejeschke

cursession undefined in ImageViewBokeh.py

Open pllim opened this issue 7 years ago • 2 comments

In the ImageViewBokeh2.update_image() method, there is cursession().store_objects(d_src), where cursession is not defined anywhere. Is this Bokeh magic or some oversight?

pllim avatar Aug 08 '17 19:08 pllim

bokeh is not yet a fully supported back end, mostly because I haven't figured out a way yet to connect the event bindings. ImageViewBokeh2 class was one possible implementation of the ImageViewBokeh class, so it is in there for reference, but not used. And probably the cursession() is from that. That is some API call from the Bokeh library.

ejeschke avatar Aug 09 '17 00:08 ejeschke

so it is in there for reference, but not used

Maybe it should be commented? Having a broken "live" code can cause some confusing traceback if someone tried to use this class. Just a thought.

pllim avatar Aug 09 '17 13:08 pllim