Kindling icon indicating copy to clipboard operation
Kindling copied to clipboard

Added a feature that highlights posts with red border that contains words/phrases from a list

Open kevinjpluck opened this issue 10 years ago • 2 comments

Hi Eric,

We found that our campfire room got quite noisy with hubot etal posting errors and warnings so a lot of critical messages got lost. So instead of retuning hubot (which is probably the sensible approach) I added this feature to kindling.

I hope you like it :-)

kevinjpluck avatar Jul 30 '13 09:07 kevinjpluck

Thank you for the pull request, Kevin.

I've encountered a few issues with the new feature.

  1. When the wordlist is empty, the highlighter throwsTypeError: Cannot call method 'split' of undefined
  2. The wordlist doesn't seem to save unless another element in the menu is clicked.
  3. The wordlist highlighting is case-sensitive (is this intentional?).

In commit ce1c3d9, I added the ability to highlight occurrences of words from a list. You may want to build upon that related feature. Maybe build a sub-option that highlights the entire message (if that's your desired effect), in addition to highlighting the keyword.

Hope that helps, and thanks again!

ejensen avatar Aug 11 '13 01:08 ejensen

Thanks Eric, I'll have a look at your issues, correct them and get back to you.

I'm a tad new to js and chrome extensions so any criticism is appreciated!

kevinjpluck avatar Aug 11 '13 09:08 kevinjpluck