HotSUploader icon indicating copy to clipboard operation
HotSUploader copied to clipboard

hotsapi.net upload support

Open sloonz opened this issue 8 years ago • 10 comments

Upload to hotsapi.net in addition to hotslogs.

Since hotslogs & hotsapi both use the same format for match ID, I could reuse most of the code of HotsLogsProvider and moved the common code to a new class ReplayUtils.

sloonz avatar Sep 13 '17 10:09 sloonz

Note that right now duplicate detection does not works ; see https://github.com/poma/hotsapi/issues/38

sloonz avatar Sep 14 '17 07:09 sloonz

Duplicate detection is now working

sloonz avatar Sep 14 '17 10:09 sloonz

We currently aren't supporting multiple provider(the API does, but the application design doesn't). In the future, we do intend to solve this, but this pull request cannot be included before that.

eivindveg avatar Sep 15 '17 18:09 eivindveg

but the application design doesn't

Do you mean GUI or architecture?

poma avatar Sep 16 '17 10:09 poma

Both. I do wish to get support for multiple providers in, but I do want to do it in a way every provider can be toggled. One thing I have been working on is a configuration panel, which would allow us to do that.

GUI design-wise, we'd also need to fiddle with the list, such as displaying icons for targets a replay has been uploaded to before it's fully uploaded and removed from the list. This shouldn't be too complex, but the former issue needs to be resolved first.

eivindveg avatar Sep 16 '17 11:09 eivindveg

@eivindveg thinking about helping with the integration and other necessary related tasks. Whats your vision for the UI/Settings panel?

ixidion avatar Sep 23 '17 13:09 ixidion

I appreciate any help with the design/layout of the settings panel. I'd like to design the internal settings engine myself before it's reviewed.

eivindveg avatar Sep 23 '17 17:09 eivindveg

We will be integrating this pull request in 2.2 along with multi-provider support. Keep in mind that this will result in conflicts for this pull request which will have to be resolved. To make this easier, please prepare the following information:

  • Name of your provider, for example HotsLogs
  • ID of your provider, for example hots-logs
  • A small(16x16 or 32x32) logo for your provider, such as a favicon

eivindveg avatar Sep 23 '17 21:09 eivindveg

For hotsapi:

poma avatar Sep 23 '17 22:09 poma

@eivindveg curious if you've moved ahead with multi-provider support? Working on macOS support for Hotsapi.Uploader (https://github.com/poma/Hotsapi.Uploader/issues/5) and this was linked as a possible solution.

MGatner avatar Jun 08 '18 01:06 MGatner