Thomas Kratz

Results 57 comments of Thomas Kratz

Unfortunately I have the same issues when running in gitpod vscode browser. Even when I open the folder manually it still has tons of unresolved references.

When the built-in attributes come from builtinDocumentAttributeProvider and the file suggestions come from AsciidocProvider the context check is (current state) made in AsciidocProvider. Should we set the sort prefix on...

I'll try to set up a PR in the next few days.

When trying to set this up, I found that in the context on an include the attributes are provided by `AttributeReferenceProvider` which uses `document.getAttributes()` . That completely makes sense, but...

https://github.com/asciidoctor/asciidoctor-vscode/blob/b65f1c171ce828e71f784cfdf8c5f2bc6e429f66/src/features/builtinDocumentAttributeProvider.ts#L12-L19 The attributes from the json file are only shown, when the line starts with a colon. Actually there are also duplicates then coming from the `AttributeReferenceProvider`.

![Bildschirmfoto vom 2022-08-21 10-41-53](https://user-images.githubusercontent.com/1238044/185783124-4b0f1fd0-ae67-483b-9c8a-f8a65e11a9d9.png) Scroll down a bit ![Bildschirmfoto vom 2022-08-21 10-42-09](https://user-images.githubusercontent.com/1238044/185783131-4dba3f58-cf5d-4b0a-9e2c-7c0471a93478.png)

Currently an `a_` prefix is in use, but we could change that. I gave this a try to show the files upfront yesterday and it works like a charm. I...

That's the case. The duplicate comes from AttributeReferenceProvider.

I see the same issue here with ng 13.0.1 and generator 5.3.1-SNAPSHOT

I think I could use it as a library for my java9/jshell fork