frontend-maven-plugin icon indicating copy to clipboard operation
frontend-maven-plugin copied to clipboard

Published 20 hours ago • verified publisher icon eirslett

Support for pnpm v6

Open noblica opened this issue 3 years ago • 21 comments

Currently, the pnpm install looks for pnpm.js, yet in version 6 they renamed the file to pnpm.cjs, so the install breaks. Could we get support for this as well?

Tagging @bmarwell , since he did the awesome pnpm PR previously :)

noblica avatar Apr 21 '21 11:04 noblica

I suppose we could check for the existence of pnpm.cjs and then use that, otherwise fallback to pnpm.js. Feel free to open a PR.

eirslett avatar Apr 21 '21 15:04 eirslett

I might do this! I hope I can do this by the end of the week.

bmarwell avatar Apr 21 '21 15:04 bmarwell

Hey @bmarwell , any news about this? :slightly_smiling_face:

noblica avatar May 11 '21 13:05 noblica

No, but I have it on my roadmap. Once I get to work, it is probably done quickly. ;)

bmarwell avatar May 11 '21 13:05 bmarwell

Fantastic, thanks @bmarwell

karlvr avatar May 12 '21 04:05 karlvr

Thanks a lot @bmarwell ! I see @eirslett released a new version of frontend-maven-plugin. That's great! 🎉

But it seems that this PR didn't make it in that release, or am I wrong? I'm still getting an error, that the pnpm.js file cannot be found :thinking: Screenshot from 2021-05-13 11-21-49

noblica avatar May 13 '21 09:05 noblica

It was part of the release, so something must be wrong I suppose.

eirslett avatar May 16 '21 12:05 eirslett

D'oh! The PnpmRunner.java is initialized before the actual download seems to occur. :-( Need to rethink how this could be made possible. Can someone please create a minimal project so we can add this as an IT?

bmarwell avatar May 17 '21 18:05 bmarwell

Since this is not done, should this issue be reopened?

noblica avatar May 28 '21 10:05 noblica

Yes!

bmarwell avatar May 28 '21 13:05 bmarwell

@eirslett Any chance this gets into a next release any time soon?

peschee avatar Jan 01 '22 07:01 peschee

@eirslett Any chance this gets into a next release any time soon?

It should be released in 1.12.1 I think. EDIT: well it is released, but as you can read from the thread, there's a bug in the implementation.

eirslett avatar Jan 01 '22 21:01 eirslett

Hi @eirslett the "non-fix" was merged, but it did not work. Everything gets initialized before we can chack for the proper binary. :(

https://github.com/eirslett/frontend-maven-plugin/issues/966#issuecomment-842527971

bmarwell avatar Jan 01 '22 21:01 bmarwell

So does this mean pnpm v6 is not supported at this moment @bmarwell?

Jdruwe avatar Feb 16 '22 12:02 Jdruwe

Haven't tried it for a while now, but yes => That is what I read from it.

bmarwell avatar Feb 16 '22 13:02 bmarwell

Can someone please create a minimal project so we can add this as an IT?

Will code for minimal project. 😅

bmarwell avatar Apr 16 '22 17:04 bmarwell

The simple command for u 🐧: npx --yes pnpm@6 install

caocuong2404 avatar May 27 '22 09:05 caocuong2404

We know how to install it, but we don't know the version that early in the process (the API is a little bit too static).

bmarwell avatar Jun 02 '22 11:06 bmarwell

Still having troubles with this :( Using the plugin version 1.11.3 as I'm forced to use Java 8 and Maven 3.5.4 With nodeVersion 18.14.0 and pnpmVersion 7.26.3

eloyAM avatar Feb 07 '23 12:02 eloyAM

I switched back to npm for now, because I was not able to fix this using the current API.

bmarwell avatar Feb 08 '23 13:02 bmarwell

This issue seems to have been resolved, I am no longer able to reproduce it any longer.

jonkoops avatar Oct 23 '23 19:10 jonkoops