frontend-maven-plugin icon indicating copy to clipboard operation
frontend-maven-plugin copied to clipboard

Add proxy environment variables for npm postinstalls

Open Cavva79 opened this issue 7 years ago • 4 comments

Summary

Found that for postinstall script, such openlayers 4 has, in a proxy network, this plugin is not passing right the proxy to node.js running the script.

Tests and Documentation

This fixes issue #657. I tested and it seems to work with openlayers 4.6.4

Cavva79 avatar Dec 28 '17 09:12 Cavva79

@eirslett I think this pull request may fix also issue #700, do you have any plans to merge?

Cavva79 avatar May 08 '18 07:05 Cavva79

Any chance of getting this merged?

xmj avatar Aug 09 '19 11:08 xmj

@eirslett We would also and still appreciate the merge of this pull request.

MichaelCkr avatar Aug 28 '20 15:08 MichaelCkr

@Cavva79 or @eirslett do you guys have any news on this PR? 😃

ironijunior avatar Jan 21 '21 13:01 ironijunior

Hey @Cavva79 / @eirslett , Any idea about this PR, please?

josehenriqueventura avatar Jun 27 '23 12:06 josehenriqueventura

Sorry, looks like I botched the merge commit. There is a conflict against the master branch, could somebody please just pick up the code from this PR and make a new PR that works against the latest master? I'll promise to merge it!

eirslett avatar Jun 27 '23 22:06 eirslett

@eirslett there you go https://github.com/eirslett/frontend-maven-plugin/pull/1095

josehenriqueventura avatar Jun 28 '23 10:06 josehenriqueventura

@Cavva79 do you want to fix this PR? I should have asked it first.

josehenriqueventura avatar Jun 28 '23 13:06 josehenriqueventura

@josehenriqueventura go ahead. I am unable to fix it now ☺️

Cavva79 avatar Jun 28 '23 13:06 Cavva79