sage icon indicating copy to clipboard operation
sage copied to clipboard

make go-lint seems to be ignoring sibling files in folders where there is a go.mod/go.sum file

Open christos-einride opened this issue 2 years ago • 1 comments

At least in the evolve backend folder, when I run make go-lint, any issue in the .go files that are siblings to go.mod/go.sum files is completely ignored.

Steps to reproduce:

  1. go in the backend folder of the evolve repo
  2. add any .go file in that folder (as long as it is in the same folder with a go.mod/go.sum folder)
  3. type any garbage text you want in it (aka. sleep on your keyboard)
  4. run make go-lint from the same folder (/backend)

linter will report that everything is fine. What I would expect is that the linter would catch the garbage text.

Extra info: Having done the above 4 steps, in the same repo, if you actually go into the /gateway folder and run make go-lint in there, this will report the issue. The implementation of the two functions seems to be different. I would actually expect that linting in the gateway folder would not report any issues in the backend folder.

Couldn't say if this is a sage issue or if we are doing something weird, so I thought of creating an issue here as a first step. :) :pray:

christos-einride avatar May 04 '23 12:05 christos-einride

This issue has been open for 365 days with no activity. Marking as stale.

github-actions[bot] avatar May 06 '24 08:05 github-actions[bot]