gh-dependabot icon indicating copy to clipboard operation
gh-dependabot copied to clipboard

Keyboard shortcut for open in browser collides with previous page

Open Tenzer opened this issue 1 year ago • 0 comments

First of all, thank you for this utility. It's handy for quickly going through dependency updates across many repositories.

When I open a PR in a browser, I notice that the list of PRs goes back to the previous page. This seems to be because the same keyboard shortcut is used for both actions:

https://github.com/einride/gh-dependabot/blob/14bb44f63a4ba2539e0b01be191a7424beabc3ca/tui_list.go#L49-L52

https://github.com/charmbracelet/bubbles/blob/e857875f2a75bd9ed464585dd53d5065e4dbe61f/list/keys.go#L45-L48

I don't know if it's possible to change/remove the keyboard shortcut for the list. If not, I would suggest changing the keyboard shortcut for opening the page in the browser to some other letter, although I don't have a good overview of which letters may or may not be in use.

Tenzer avatar Sep 27 '22 09:09 Tenzer