can-go icon indicating copy to clipboard operation
can-go copied to clipboard

Published 20 hours ago • verified publisher icon einride

Skip DBC comments

Open RangelReale opened this issue 1 year ago • 3 comments

RangelReale avatar Dec 27 '23 12:12 RangelReale

Can you describe a little bit about the current behavior and how this changes that?

maxekman avatar Jan 16 '24 14:01 maxekman

Currenly comments are not ignored, so when parsing a line like this:

VERSION "2.0" // Another comment.

we get errors, as there is supposed to be no more data after the version string. This change just makes the parser skip all comments.

RangelReale avatar Jan 16 '24 16:01 RangelReale

According to http://www.mcu.so/Microcontroller/Automotive/dbc-file-format-documentation_compress.pdf it seems like the comment format to use in DBC files are (* COMMENT *), not // COMMENT.

We're hesistant to include non-standard behavior, as it could potentially conflict with other tooling.

Feel free to update the PR with this comment style, if you still want this feature :)

Jassob avatar May 16 '24 15:05 Jassob