Redirector icon indicating copy to clipboard operation
Redirector copied to clipboard

No Sync option in Firefox

Open neubland opened this issue 5 years ago • 13 comments

I use Redirector on Firefox 68 on Windows 10. There is no "storage area" option, neither in the about:addons options, nor in the moz-extension://... options.

neubland avatar Aug 05 '19 16:08 neubland

I didn't write the sync code myself, but as far as I can remember it got removed again because of problems with Firefox.

einaregilsson avatar Aug 06 '19 08:08 einaregilsson

@neubland I did some digging and found that it was disabled for Firefox in #128. See #127 for root cause. In short, please complain to Mozilla instead of here; thanks.

FranklinYu avatar Apr 07 '20 04:04 FranklinYu

Hi!

I enabled sync option by rewriting DOM, and it looks works (I used Firefox 75). This problem might be already solved, and it might be already okay to display this option by default. https://github.com/einaregilsson/Redirector/issues/127

@einaregilsson Could you please check it?

ledyba avatar Apr 17 '20 00:04 ledyba

Not working on this at the moment, but will check before next release.

einaregilsson avatar Apr 17 '20 08:04 einaregilsson

That’s weird; documentation still says that it’s not ready on Firefox:

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/StorageArea/getBytesInUse#Browser_compatibility

I suspect that this API wasn’t triggered by your test. I guess you need to go over 100kB to see whether it breaks.

FranklinYu avatar Apr 21 '20 01:04 FranklinYu

Hmmm.... You are right.

The source code says getBytesInUse is not supported yet. (Even though I can sync the settings very well between Linux, Windows and mac OS!)

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/schemas/storage.json?q=getBytesInUse&redirect_type=single#69-97

ledyba avatar Apr 21 '20 10:04 ledyba

It seems it's supported since Firefox 78?

cdfa avatar Dec 12 '20 15:12 cdfa

Is it possible now with the current FF version?

Elaborendum avatar Mar 02 '22 03:03 Elaborendum

I confirm that sync is working despite being hidden in Firefox 119.0 - macOS Ventura 13.6.1

image

To enable sync

  • go to Redirector rules page
  • open Developer Tools, go to Console
  • call this function
show("#storage-sync-option")

You can then click the checkbox.

As others users reported, you can also call directly toggleSyncSettings()

You may want to backup your rules before enabling sync, just in case

gforien avatar Nov 02 '23 16:11 gforien

@gforien So I tried this but my redirects don't seem to stick. I have a backup, but every time I import it and reload the page they are just gone. Granted I haven't edited any of my redirects in my long time so maybe I'm just forgetting something basic, but I can't figure it out.

Elaborendum avatar Nov 02 '23 17:11 Elaborendum

@Elaborendum I did the same as you, but after importing my backup and reloading the page, everything was still there.

What is plugin version/ FF version / OS ? Do you have any logs in the DevTools Console or popup messages in Redirector ?

gforien avatar Nov 02 '23 17:11 gforien

@gforien I'm on Redirector 3.5.3/Firefox 119.0/Windows 10 22H2

No popups but I get this on the console:

Received redirects message, count=0
TypeError: response is undefined

Line 2 occurs after importing my backup

After trying numerous times by turning the sync on and off, decided to just leave it off, even getting the "using local storage" message, but now nothing saves. I keep getting "response is undefined". Reinstalling the extension fixed it, still can't use synced storage though.

Elaborendum avatar Nov 02 '23 18:11 Elaborendum

Working for me after the following steps:

  1. Confirm that syncing of add-ons is enabled in your Firefox settings.
  2. Export existing Redirector rules, as they will be deleted in this process.
  3. Run show("#storage-sync-option") in the Developer Tools console, on the Edit Redirects add-on page.
  4. Click the checkbox to enable.
  5. Refresh. For me, my existing rules were deleted.
  6. Import Redirector rules from the backup, and delete the example rule.
  7. Refresh again to confirm the rules persist and check the console for any errors.

Redirector 3.5.3, Firefox 123.0.1, Windows 11 23H2

WD40andTape avatar Apr 13 '24 15:04 WD40andTape