InsertIcons icon indicating copy to clipboard operation
InsertIcons copied to clipboard

Use NuGet to reference ResourceLib and use the latest version

Open samhocevar opened this issue 3 years ago • 5 comments

Hi! I have been successfully using InsertIcons for WinCompose for years but I have always had random crashes happening, and with recent changes in the Microsoft SDKs it just stopped working. While checking ResourceLib I noticed they had made a lot of bugfixes since 2012, including an off-by-one issue with multiple icon insertion, and one for compatibility with WPF applications.

This PR switches the ResourceLib dependency to NuGet so that it is trivial to upgrade to the latest version. Hope you find this useful.

samhocevar avatar May 18 '21 21:05 samhocevar

Thanks. I'll try to get this merged and do a release when I have access to a windows machine again, I don't have one right now :)

einaregilsson avatar May 19 '21 10:05 einaregilsson

@einaregilsson I also find this library useful. If you're interested in having it maintained while you don't have a Windows machine, I'm happy to help.

robdplatt avatar Jul 13 '21 02:07 robdplatt

@robdplatt Thanks, but I'll get it sorted next week, and do a release then :) No problem with the new version, no crashes or anything like that?

einaregilsson avatar Jul 15 '21 11:07 einaregilsson

@einaregilsson Works just the same with the updated ResourceLib. I did update a fork to .NET 4.7.2 for my projects.

robdplatt avatar Jul 19 '21 14:07 robdplatt

Will this work for programs built with .NET 6 without removing it's assembly metadata?

AraHaan avatar Oct 13 '22 01:10 AraHaan