Hans-Christoph Steiner

seems like keeping a reference, then closing it in `onDestroy()` could work

Here is also some related info and debugging: https://gitlab.torproject.org/tpo/core/tor/-/issues/32729

I don't think `ParcelFileDescriptor` is in use at all here. That's for serializing things for `Intents`.

Seems like this might need to be handled in _jtorctl_, since it's `TorControlConnection` is what is using those streams.

If that commit works, there should be a build available in the artfacts in this job, once it completes: https://gitlab.com/eighthave/tor-android/-/pipelines/416708252

I won't have time to dig into this for a bit. If you want to try the naive closing, it built here: https://gitlab.com/eighthave/tor-android/-/pipelines/416958111

That test case looks very promising!

@grote can you tell what is calling close each time? @asn-d6 @ahf this seems to crash the same way as https://gitlab.torproject.org/tpo/core/tor/-/issues/32729 and @grote has put together a repro test case....

@akwizgran sounds like you're thinking that the crash isn't so much about the Control Socket but rather knowing when to call Tor's free/shutdown methods. That was my impression also, when...

@syphyr thanks for doing this. Can you tell us about what kind of testing you did? Are there any notable bug fixes included here?