Hans-Christoph Steiner

Results 514 comments of Hans-Christoph Steiner

Looks like the only thing of concern would be a malicious URL that exploits `git-remote-https`. I wonder if it would be worthwhile to sanitize the URL first? ```console $ git...

I would like to write tests, I looked around through the test suite, but it still escapes me how to structure these tests. Since these options affect how `git` is...

FYI this is my very simple test suite: ```python #!/usr/bin/python3 import os import git import tempfile for url in [ '[email protected]:fdroid/ci-test-app.git', 'ssh://gitlab.com/fdroid/ci-test-app.git', 'git://gitlab.com/fdroid/ci-test-app.git', ]: print('====================', url) d = tempfile.mkdtemp(prefix='foo_py_') repo...

F-Droid has been using this approach for years, and will switch to this code once it is merged. As for the name, I'm open to suggestions. I used the word...

I think this is ready to go. Let me know if there is anything I can provide to help with the review and merge.

@EliahKagan anything I can help with? Any other blockers here? I rebased this on the latest _main_.

The test failure seems to be unrelated, something with it can't connect to _localhost_

Sounds like a good way to work. I've only contributed to Androguard, but I have looked at related codebases, like appknox/pyaxmlparser. I was thinking it might be easier to start...

Keeping it an Androguard library maintained here works for me. I do think it is important that this new lib is published separately, like its own pypi.org entry.

FYI if some funding would help progress on this, I'm happy to help anyone apply to https://nlnet.nl/mobifree/ to work on this specific issue, or other important tasks in Androguard.