linkify-plus-plus icon indicating copy to clipboard operation
linkify-plus-plus copied to clipboard

The script breaks the contents in the "To" field on mail.disroot.org

Open RedSteel-1 opened this issue 3 years ago • 6 comments

I'm using the script, and it has an old issue: It breaks the contents in the "To" field on mail.disroot.org, when the emails are entered in the field. Steps:

  1. Log in to Disroot mail and press "New message" button.
  2. Enter some emails in the "To" field.
  3. Press somewhere outside of the field and see the results.

Could this be fixed?

RedSteel-1 avatar Nov 25 '21 20:11 RedSteel-1

Is it just a styling issue or it makes disroot unable to send emails?

eight04 avatar Dec 15 '21 11:12 eight04

Just registered an account and tried sending an email. It seems that it is just a styling issue. If you have a custom CSS extension like Stylus, you can fix it via the following style:

.linkifyplus {
  position: static;
}

eight04 avatar Dec 15 '21 15:12 eight04

Is it just a styling issue or it makes disroot unable to send emails?

it's just styling

Just registered an account and tried sending an email. It seems that it is just a styling issue. If you have a custom CSS extension like Stylus, you can fix it via the following style:

yes i can, even though it would require to do this in all 10 browsers i have in my 2 PCs, the thing is that in this case some of my contacts using this email and having the script installed by me (in particular case), as welll as (in general) many people who might not even know what "css" and "extension" is, will have to do the same, which most likely they just won't

would it be possible to have it as an update in the script that everyone who have it installed will receive?

RedSteel-1 avatar Dec 16 '21 21:12 RedSteel-1

You mean to insert CSS in the script?

Actually, I always think these site-specific features are not good ideas.

  1. It will be useful for disroot users, but it will be a useless feature for non-disroot users.
  2. Besides maintaining a script that converts text to link, I also have to maintain css code for specific sites.

There was a similar request for travis: https://github.com/eight04/linkify-plus-plus/issues/15

However, since requests are low, maybe we can consider adding them to LPP...? IDK.

yes i can, even though it would require to do this in all 10 browsers i have in my 2 PCs,

You may want to turn on sync in your script/style manager so you don't have to update all of them individually.

(You still have to turn on sync for each browser individually in case you haven't done this).

eight04 avatar Dec 17 '21 03:12 eight04

regarding sync: me and many people I know don't use something so untrusted, especially for sensitive data, in other words browser sync has always been a no-go and has never been used (moreover some browsers don't have sync)

what is LPP btw?

It will be useful for disroot users, but it will be a useless feature for non-disroot users

If adding the fix to the script: the good for the former, doesn't matter for the latter, if not: the bad for the former, still doesn't matter for the latter, The choice between making a certain group of users happy or not, go for the former :-P

RedSteel-1 avatar Dec 21 '21 16:12 RedSteel-1

what is LPP btw?

Linkify Plus Plus

if not: the bad for the former

Just want to point out that it is not bad for all of them. Only bad for people don't know how to fix it by CSS or by excluding the script.

eight04 avatar Dec 22 '21 04:12 eight04

It seems that Disroot updated their site and this is no longer an issue.

eight04 avatar Feb 16 '24 09:02 eight04