epic icon indicating copy to clipboard operation
epic copied to clipboard
verified publisher icon eic

Revert B0 dimension changes to restore reconstruction to 25.07.0 performance

Open veprbl opened this issue 1 month ago • 4 comments

This partially reverts d1be407230b6ee8cb02aaf700ee6442e4aea59de

Briefly, what does this PR introduce?

This is a workaround for #987

What kind of change does this PR introduce?

  • [ ] Bug fix (issue #__)
  • [ ] New feature (issue #__)
  • [ ] Documentation update
  • [ ] Other: __

Please check if this PR fulfills the following:

  • [ ] Tests for the changes have been added
  • [ ] Documentation has been added / updated
  • [ ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Yes

veprbl avatar Nov 11 '25 19:11 veprbl

I guess, this will not work for simulation.

veprbl avatar Nov 11 '25 20:11 veprbl

This will create overlaps with the new cryostat geometry.

ajentsch avatar Nov 11 '25 21:11 ajentsch

The overlaps appear to be small 0.05 (should be the default unit for TGeo is mm), it may be possible to wiggle something in.

veprbl avatar Nov 12 '25 03:11 veprbl

I ran it locally and it looks like the sizes in 43ff6cf3e4a97b3db9312a6a23a8548e5e7ad07c are not sufficient to recover the original performance.

veprbl avatar Nov 13 '25 21:11 veprbl