epic icon indicating copy to clipboard operation
epic copied to clipboard

New far backward dipole magnet volumes added

Open simonge opened this issue 1 month ago • 4 comments

Briefly, what does this PR introduce?

Creates the volumes of the dipole magnets in the far backward region.

Currently in the wrong position, this will be updated to the correct location, or merged into a separate PR when the beamline changes have been made.

Opened to check the naming of the components, materials are appropriate and the simplification of the CAD geometry is acceptable.

What kind of change does this PR introduce?

  • [ ] Bug fix (issue #__)
  • [x] New feature (issue #963 )
  • [ ] Documentation update
  • [ ] Other: __

Please check if this PR fulfills the following:

  • [ ] Tests for the changes have been added
  • [ ] Documentation has been added / updated
  • [ ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

simonge avatar Nov 07 '25 10:11 simonge

Simulation has all of the magnet volume as iron. image CAD images: image image

simonge avatar Nov 07 '25 11:11 simonge

Hi @simonge , Thanks for implementing this. I have a couple of questions:

  1. Why did you change the magnet names? In the lattice and drawings, we usually call them B2AeR and B2BeR. I would suggest following the same naming convention in DD4hep.
  2. What does “Bar” refer to?

Thanks

nat93 avatar Nov 07 '25 14:11 nat93

Thanks @nat93

  1. Why did you change the magnet names? In the lattice and drawings, we usually call them B2AeR and B2BeR. I would suggest following the same naming convention in DD4hep.

My mistake, now hopefully named consistently.

  1. What does “Bar” refer to?

Bar was the name I gave to the rectangular objects in the B2BeR geometry, I was hoping you could provide more appropriate names for each part of the magnet so very happy if you have the correct names and materials to swap in.

simonge avatar Nov 07 '25 16:11 simonge

Thanks @nat93

  1. Why did you change the magnet names? In the lattice and drawings, we usually call them B2AeR and B2BeR. I would suggest following the same naming convention in DD4hep.

My mistake, now hopefully named consistently.

  1. What does “Bar” refer to?

Bar was the name I gave to the rectangular objects in the B2BeR geometry, I was hoping you could provide more appropriate names for each part of the magnet so very happy if you have the correct names and materials to swap in.

@simonge , Ah, I see. Those objects should be magnet coils. For now, we can model them as copper, but later, when I start looking into TID and heat-load calculations in that region and Harshita has a more detailed model, I may refine it by adding epoxy resin and a realistic coil geometry for both magnets.

nat93 avatar Nov 07 '25 17:11 nat93