eic
Add parameters needed for 6.3 lattice and magnet visualization.
Briefly, what does this PR introduce?
Moves the code and visualization changes from https://github.com/eic/epic/pull/838/ so that it will reflect the minimal differences required to update the lattice.
Mostly this adds parameters which are set to 0 in the current configuration but need to be set in the update.
What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __
Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No
Hi, I have created a PR for reference, so everyone is aware of the upcoming updates to the IR: https://github.com/eic/epic/pull/893 Related to this PR as well.
Question: what is the element id for the yoke for? Do you intend to make that sensitive for some reason?
It was a while ago I added that so not entirely sure. I believe the visualization wasn't working correctly without a detector element and the detector element didn't work without an id. Some/all of what has been added might be unnecessary.
Looks good to me. Have not done a one to one comparison with capybara.
What was the problem with publishing the capybara here as is done in EICRecon? I didn't follow why it was added then reverted.
Looks good to me. Have not done a one to one comparison with capybara.
What was the problem with publishing the capybara here as is done in EICRecon? I didn't follow why it was added then reverted.
There were errors in running it due to the different structure of other artifacts (different directory), so it always failed the pipelines. It wasn't immediately clear how to fix it, so we reverted to avoid blocking work. I haven't found the time to get back to that. https://github.com/eic/epic/pull/859 was supposed to fix it and includes a link to https://github.com/eic/epic/actions/runs/14817178151/job/41749142343#step:7:7 that shows how it failed.
