epic icon indicating copy to clipboard operation
epic copied to clipboard

Detector ID constants use ECal*, HCal* etc, but all else uses Ecal*, Hcal*

Open wdconinc opened this issue 2 years ago • 1 comments

Environment: (where does this bug occur, have you tried other environments)

  • Which branch (main for latest released): main
  • Which revision (HEAD for the most recent): HEAD
  • Any specific OS or system where the issue occurs? no
  • Any special versions of ROOT or Geant4? no

Steps to reproduce: (give a step by step account of how to trigger the bug)

The difference in capitalization makes this error-prone, e.g. https://github.com/eic/EICrecon/pull/1070.

Expected Result: (what do you expect when you execute the steps above)

We should use a consistent capitalization.

Actual Result: (what do you get when you execute the steps above)

We aren't using a consistent capitalization.

Additional Context

Probably this can all be included in a major renaming overhaul...

wdconinc avatar Oct 11 '23 12:10 wdconinc

@veprbl fyi

wdconinc avatar Oct 11 '23 12:10 wdconinc