epic icon indicating copy to clipboard operation
epic copied to clipboard

Roman Pots visualization not working when geometry dumped into ROOT file

Open ajentsch opened this issue 2 years ago • 5 comments

Environment: (where does this bug occur, have you tried other environments)

  • Which branch (main for latest released): main
  • Which revision (HEAD for the most recent):
  • Any specific OS or system where the issue occurs? Mac/Docker
  • Any special versions of ROOT or Geant4? No

Steps to reproduce: (give a step by step account of how to trigger the bug)

  1. Produce geometry: geoConverter -compact2tgeo -input [compact_file.xml] -output [geometry].root
  2. Open resulting file using a ROOT TBrowser. Other geometry component render just fine, but not the Roman Pots. It's likely to do with the overtly complicated structure to generate the geometry.

Expected Result: (what do you expect when you execute the steps above)

I except to be able to see the detector geometry.

Actual Result: (what do you get when you execute the steps above)

I do not see the detector geometry.

ajentsch avatar Aug 03 '23 19:08 ajentsch

Some of this might stem from a ROOT bug/feature which is hopefully being fixed where the transparency of a volume is set at the material/medium level. The last volume which used that material appears to set the transparency for all preceding volumes built. https://github.com/root-project/root/pull/13402 I'm not certain this is the stem of all of the visualisation issues I've been seeing but the Roman Pots is not alone. A fix in ROOT will likely take a while to propagate to eic-shell if that is in fact the problem.

simonge avatar Aug 07 '23 20:08 simonge

Ahh okay this is good to know. I will do some tests with that in mind to see if I can get the visualization to work. It's just odd because the RP and OMD are very similar and one works while the other doesn't. Thank you!

On Mon, Aug 7, 2023, 4:37 PM Simon Gardner @.***> wrote:

Some of this might stem from a ROOT bug/feature which is hopefully being fixed where the transparency of a volume is set at the material/medium level. The last volume which used that material appears to set the transparency for all preceding volumes built. https://github.com/root-project/root/pull/13402 I'm not certain this is the stem of all of the visualisation issues I've been seeing but the Roman Pots is not alone. A fix in ROOT will likely take a while to propagate to eic-shell if that is in fact the problem.

— Reply to this email directly, view it on GitHub https://github.com/eic/epic/issues/493#issuecomment-1668545857, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADABSFZQGH4TOVMEJRMUMPDXUFGW7ANCNFSM6AAAAAA3DHVBQU . You are receiving this because you authored the thread.Message ID: @.***>

ajentsch avatar Aug 07 '23 20:08 ajentsch

Removing other detectors or swapping the order they are included in the main xml file changes the visualisation, it's very strange

simonge avatar Aug 07 '23 20:08 simonge

With the ROOT master, you should use TGeoVolume::ResetTransparency(char value) to set per volume (and not per material transparency). Calling ResetTransparency() with no value will use transparency per material (default behavior). See: https://github.com/root-project/root/pull/13402

agheata avatar Aug 08 '23 09:08 agheata

@ajentsch, I have this feature in my visualization of geometry code where I loop over all the volumes and we can specify transparency and color for each volumes. The code can be used easily for event-display also.

Simple-Shyam avatar Aug 08 '23 12:08 Simple-Shyam