epic icon indicating copy to clipboard operation
epic copied to clipboard
verified publisher icon eic

fix: dRICH sensor material should not be `AirOptical`

Open c-dilks opened this issue 3 years ago • 3 comments

Briefly, what does this PR introduce?

Close #18

What kind of change does this PR introduce?

  • [ ] Bug fix (issue #__)
  • [ ] New feature (issue #__)
  • [ ] Documentation update
  • [x] Other: improve material property tables

Please check if this PR fulfills the following:

  • [ ] Tests for the changes have been added
  • [ ] Documentation has been added / updated
  • [ ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

c-dilks avatar Sep 08 '22 15:09 c-dilks

@c-dilks @chchatte92 Is this issue solved? When this file moved, git didn't understand that and marked it as deleted, and the new one is treated as a different one, so you can't easily compare/merge. Also, the current one looks to my eye substantially different, so I can't easily identify which instance of AirOptical needs (or needed) to be changed.

kkauder avatar Dec 12 '23 21:12 kkauder

@chchatte92 We are tagging a new release for the February campaign soon. Is there anyone working on this PR? Is it expected to be ready for February release?

rahmans1 avatar Feb 06 '24 19:02 rahmans1

@chchatte92 We are tagging a new release for the February campaign soon. Is there anyone working on this PR? Is it expected to be ready for February release?

Dear Sakib, I will get back to you soon (either later today or in the weekends)

chchatte92 avatar Feb 09 '24 11:02 chchatte92