Eric Huss

Is there some context for this change? Has it been discussed by the lang team?

@RalfJung Is this ready to merge? Were there any changes since this was written?

Closing in favor of #1544, thanks!

Oops, didn't see the upstream hadn't merged, yet. I assume it will, but usually we wait just in case.

Thanks!

@RalfJung Can you review this?

I asked over at https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/object.20safety.20of.20Self.20in.20supertraits for some suggestions. Someone noted https://github.com/rust-lang/rust/issues/88904 as a strange edge case, but I am uncertain if that is just a bug. What you have suggested...

I'm a bit confused, as I believe `.inst` is a valid directive still. What is the difference between them? Is there some more information about this change? @Amanieu Can you...

@joshtriplett Do you want to *add* `.insn` to the guaranteed directive list? (Not what this PR does, it should be *added* not replaced.) Looks like .insn was added to gnu-as...

The CI errors are fine, this won't be merged until the stabilization hits nightly which should resolve them.