Eric Huss

Has the lang team approved the new attribute?

It has been the policy as long as I'm aware that the lang team is responsible for attributes. For example, they recently approved the `debugger_visualizer` attribute. I would not expect...

> I assume this would include the ability to specify those features in both compiler flags and #[target_feature] `-C target-feature` generally doesn't restrict which options you can use. This is...

I'm not sure who to assign. r? @compiler-errors

It looks like you are linking against a homebrew installed version of libgit2. However, since #708, libgit2-sys is expecting a recent master version (which is still called 1.1.0). @alexcrichton How...

As a side note, this test fails for me on both macos and linux with: thread 'branch::tests::name_is_valid' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: -1, klass:...

Can you say how you are measuring the memory usage? Allocators sometimes don't release unused memory back to the operating system, so perhaps it was just a spike?

I'm not sure what those screenshots are from, but if that is from a process viewer, I think that would be expected to some degree. As I mentioned, allocators won't...

Thanks! Can you add a test for this at the bottom of the file?

I think removing the legacy support would be fine, though that would need to be deferred to 0.5. I don't think we can change them to hard errors as that...