Eric Huss

Results 784 comments of Eric Huss

Cargo uses `rustc --print=split-debuginfo` to determine what options are supported. Indeed, it looks like `--print=split-debuginfo` does not take `-Zunstable-options` into consideration in its output.

I think the confusion may be that the *contents* of `git_buf` are what matters, not the actual outer struct. You can move and copy and duplicate a `git_buf` just fine,...

It's difficult to say without looking at the actual libgit2 functions you want to wrap. I'm not familiar with the "filter framework", but if you could point to specific libgit2...

That looks like it would probably work to me. It is kinda strange that `git_filter_buffered_stream_new` is undocumented, whereas the rest of the filter api is documented.

@jyn514 I still get various linking errors on aarch64-unknown-linux-musl with the latest nightly (rustc 1.72.0-nightly (cb80ff132 2023-07-07)): ``` = note: /usr/lib/gcc/aarch64-alpine-linux-musl/12.2.1/../../../../aarch64-alpine-linux-musl/bin/ld: /root/.rustup/toolchains/nightly-aarch64-unknown-linux-musl/lib/rustlib/aarch64-unknown-linux-musl/lib/libcompiler_builtins-62c49e978c93efe6.rlib(45c91108d938afe8-cpu_model.o): in function `init_have_lse_atomics': /cargo/registry/src/index.crates.io-6f17d22bba15001f/compiler_builtins-0.1.91/./lib/builtins/cpu_model.c:1051: undefined reference to `getauxval'...

https://github.com/rust-lang/rust/issues/89626#issuecomment-1642423512 contains my investigation and some workarounds.

I'm tentatively marking this t-libs-api, but I don't actually know if that's the right team assignment. It does seem like there is a lot of background and prior-art that isn't...

The links seem to work for me. For example, clicking the `3` here goes to the bottom of the page. Can you say which browser and OS you are using?...

Oh, sorry, I misunderstood. Posted #1303.

@bors r+ rollup