Eric Huss

Results 742 comments of Eric Huss

@Veykril or @HKalbasi Would either of you be interested in helping to get this PR over the line? Are either of you familiar with how they are implemented? I am...

Thanks! I'm not sure exactly how to make progress, but perhaps some questions might help to get started: 1. Have you carefully reviewed this PR? If not, would you be...

Thanks again fee1-dead, and sorry for the super long delay.

Yes, I believe this can be closed, thanks!

It looks like there are some changes in the implementation recently. Should those be reflected in the documentation here? For example: * https://github.com/rust-lang/rust/pull/108651 — It might not hurt to explicitly...

@iav can you file a new issue, that seems unrelated to this one.

> However, it seems to me that overriding debuginfo with overrides currently does not even work. What did you use to determine if debuginfo was generated? I tested, and saw...

You have to be careful about whether you are using something that involves generics or `#[inline]`. Generics will get instantiated in the crate where they are used (not defined), and...

Thanks for the report! I believe this is expected behavior, as pulldown-cmark closely follows [CommonMark](https://spec.commonmark.org/). In one of these cases, I believe it is the [right-flanking delimiter rule](https://spec.commonmark.org/0.30/#right-flanking-delimiter-run) which prevents...

@tmandry Is this something you can review (or direct to someone who can)? I can't tell if this is changing the RFC in a meaningful way, or just clarifying it....