Eric Huss

Results 735 comments of Eric Huss

> As for balancing noise vs help, we intentionally made it so we only emit 1 brief line for the entire run because of this. I personally suspect this one...

> Those are usually bugs in the compiler _emitting_ the lint, not rustfix itself, and my impression is that both T-clippy and T-compiler are good about fixing broken suggestions pretty...

Sorry, I don't think the unwillingness to merge a PR is a sign that a crate is unmaintained. `jobserver` is one of our core dependencies, and I would prefer to...

I'm going to close as this is unlikely a change we want to make at this time. If there are specific issues related directly to Cargo, it would be best...

I would prefer to not modify `CompileMode` as that breaks the abstraction with the lower-level code knowing about higher-level concepts like "install". As mentioned in https://github.com/rust-lang/cargo/pull/9576#issuecomment-913046066, is it possible to...

`-vv` should show the output. Does that work for you?

I don't recall exactly how crater/rustwide work, but I believe they use rustup. If so, and if the crater machine has been updated to rustup 1.25, then this is likely...

My script has a few other patterns that will match other build scripts and found 38 instances in `pr-100046`: ``` build-fail/gh/charlag/rusty-bird/5d388381d1f36b4bd3182c3b41ecc030716e07df/master#59d99f56d8888b0e5a5866d6418df3ca1bb90013.txt: panicked at 'unexpected -vV format build-fail/gh/charlag/rusty-bird/5d388381d1f36b4bd3182c3b41ecc030716e07df/try#d76952bc2a74b981479554f7e1e2c6f8a8c3e3bf.txt: panicked at 'unexpected...

Unfortunately tables with open-ended keys cannot be easily fetched via environment variables. #5416 contains a deeper discussion of the problem. This is generally a duplicate of #5416. However, I think...

And #9301 discusses the issues with `cargo config`. Currently it just blindly looks for env vars starting with `CARGO_`. It can't know which environment variables will actually get used.