Erik Huelsmann
Erik Huelsmann
The branch currently assumes: * Negative sell price is never intentional and always an indication of this problem (I can't imagine the sum of cost of parts into the assembly...
@einhverfr I chose for (2). Because the correction is created as a batch with a transaction per (affected) month, users will be able to reopen their books and change the...
For now, I'm not going to address #8351: Doing that will incorrectly loose the COGS relationship with the original posting items, because re-saving deletes the acc_trans lines, without retaining the...
Even though there's still community support for 1.10, it's simply too complex to backport all the required commits to fix this in 1.10 (as there's not just this commit, but...
@ledgersmb/core what should be the order of precedence here? ECA billing address -> ECA sales address -> entity billing address -> entity sales address? Or ECA billing -> Entity billing...
In 1.11 this is still a problem.
I've identified the cause to be https://github.com/ledgersmb/LedgerSMB/blob/a8ff6d69e642d8ea65f9afc6fd381851b3ec641a/old/lib/LedgerSMB/GL.pm#L278 in combination with https://github.com/ledgersmb/LedgerSMB/blob/a8ff6d69e642d8ea65f9afc6fd381851b3ec641a/old/lib/LedgerSMB/GL.pm#L315-L316 Which means that on saved transactions the fx setting is overruled with the saved data on every "Update" roundtrip.
I'm going to hold off for this on 1.12 until more fixes for overpayments come in.
@einhverfr given your remarks that overpayments doesn't really work at this moment (on 1.12), I think it makes more sense to include this PR into a larger backport which you're...
(Meaning I propose to close this PR and integrate)