Enrico Tröger

Results 150 comments of Enrico Tröger

Apart from the comments above, LGBI. I would test it on Linux and Windows when my questions are answered.

Sorry for the late response. I can't reproduce the described behavior with your example. It results in a message like (stripped unrelated fields for readability): ```json { "message": "some message.",...

I just tried with your code again, except that I replaced the logger with a standard Python logger instance and added the handler via `logger.addHandler(logstash_handler)` and got the expected result....

Basically a PR is ok but I would like to understand what's the difference and why it works for me with your example and why not for you.

A simple solution could be to seperate the events in Logstash by the logger name.

> > A simple solution could be to seperate the events in Logstash by the logger name. > > Can I work on this issue? What exactly do you want...

ECS sounds great, hopefully it will work and makes the logging world a bit better and more structured. I think I will implement it here as well, just not yet...

Thanks for the detailed report! I'm currently quite limited on time, so it might took some time to look into it.

I had a look at it but unfortunately, I'm not able to reproduce it, not even with your great test setup. ![pla_py37_memory_issue63](https://user-images.githubusercontent.com/617017/116671051-076e8380-a990-11eb-8859-1435b253f1b5.png) As you can see, I had the test...

> I also found out that the REAL reason for RAM leakage was that > > https://github.com/eht16/python-logstash-async/blob/018d238e3f76b97def3b279b0226d8e326bd3dee/logstash_async/worker.py#L49 > > were getting big too fast. Not sure we could do anything...