ehsannarmani
Add support for Js target
Hi @vidicunt, thank you, i appreciate your interest for making PR and contribute. I have some questions:
-
we are currently supporting wasm js, what's the diffrence between wasmJs and Js target? i mean what's the use of it for this project and what's the advantages of that? (I tested the output of js target and searched in google, but i did not get the diffrence between output of wasmJs and Js)
-
is there any reason why you updated dependencies or minSdk of android app under the 'Add support for Js target' title?
Hello!
- WasmJs is not supported on iOS versions < 18.2, or other legacy browsers not supporting wasm-based GC, thus the Js variant is needed. There is a gradle task ./gradlew composeCompatibilityBrowserDistribution which compiles for both Js and WasmJs.
- No reason. Another PR for updating dependencies may be created.
Ok, thank you for explanation. Then i will be greatful if you rollback version updates and fix commit history.
Done. Mind that I updated the compose version, since previous compose versions don't work properly with the Js target.
Thanks. Could you please clean up the PR so the final commit history contains only the valid changes (no revert commits)? After updating, please push with --force to update this PR.