EunHyunsu
EunHyunsu
@djelinski Thanks for the feedback! Made all the changes: - Now using `cause.getCloseCause()` for consistency - Merged sendGoAway methods as suggested - Test now verifies unprocessed stream retries with lastStreamId=1...
@djelinski Updated per your suggestions: - Switched to POST requests (only retried when unprocessed) - Sending all 3 requests at once to test race conditions - Dynamic lastStreamId based on...
@djelinski Fixed the intermittent test failures: - Removed `close()` call after GOAWAY to avoid connection reset errors - Server now relies on Http2TestServer for connection cleanup - Tested 10 times...
@djelinski I moved the goAwaySentLatch.await() back to its original position (after the first request, before second/third). However, after testing locally, I'm seeing the same behavior - all 3 requests create...
@djelinski Oops, you're right! I moved `goAwaySentLatch.await()` back to its original position and now it works as expected - only 1 connection is created initially, and the other 2 are...
@djelinski Thanks for the explanation. That makes sense. If there’s an opportunity in the future, I’d be happy to help clean that part up as well. Appreciate your guidance.
@dfuch Thank you for the thorough review. I've applied `Utils.adjustTimeout()` to both timeout values as you suggested. Also, thanks for the tip about `HttpResponse::connectionLabel()` - that's really helpful to know...
> Thanks for the updates. LGTM. Thank you!