hcipy icon indicating copy to clipboard operation
hcipy copied to clipboard

Add Keck Lyot stop in L band

Open ivalaginja opened this issue 2 years ago • 4 comments

Move to here from #155 since @vkooten and I weren't sure about how exactly to deal with some details of the Lyot stop and we want to merge the Keck aperture asap.

ivalaginja avatar Feb 25 '23 10:02 ivalaginja

Codecov Report

Merging #171 (40dcb37) into master (b435bcb) will decrease coverage by 0.41%. The diff coverage is 2.70%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   80.73%   80.32%   -0.41%     
==========================================
  Files          95       95              
  Lines        7060     7097      +37     
==========================================
+ Hits         5700     5701       +1     
- Misses       1360     1396      +36     
Impacted Files Coverage Δ
hcipy/aperture/realistic.py 86.12% <2.70%> (-4.99%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Feb 25 '23 10:02 codecov[bot]

@vkooten @ivalaginja What's the progress on this? Have those details been figured out?

ehpor avatar Nov 06 '23 22:11 ehpor

Unfortunately I believe this is a dead-end PR without a plan forward. We could reach out to @vkooten offline to check with her, but in my opinion this can be closed without merging.

ivalaginja avatar Nov 06 '23 22:11 ivalaginja

@ivalaginja Reached out to @vkooten on a hopefully current email.

ehpor avatar Nov 06 '23 23:11 ehpor