wavefront_control submodule

[aditya-sengupta]

I'd like to add tip-tilt wavefront control strategies to HCIPy and saw that there's a wavefront_control module that's currently empty. I wanted to see if there were any plans to develop this functionality already, before I start adding to it? (Also this should be labelled "enhancement" but I can't find where to set that, sorry!)

[ehpor]

A long time ago (in 2018) @vkooten and I worked on integrating control into hcipy, so this is definitely something we want. Due to time limitations we never finished that. You can check out the implementation back then in the controllers branch (https://github.com/ehpor/hcipy/tree/controllers). Feel free to revive that, or start your own branch for figuring out the right way of doing things. If I remember correctly, I was fairly happy with the architecture of that branch (aside from the nomenclature, which was honestly terrible), and we were mainly working on the implementation details.

Functions for centroiding/centroid finding are definitely appreciated. I always roll my own when I need them, but it's way better to have some implemented inside hcipy directly. For control algorithms, I'm not aware of any algorithms that are necessarily only for tip-tilt. In case I'm not mistaken with that, I'd prefer the implementation to be more general, like the branch I talked about, and not specifically for tip-tilt only.

[vkooten]

Hi @aditya-sengupta! As @ehpor there is an empty branch but nothing in there. I am not even happy with the architecture of the branch hence why I never did more work on it as I don't think it is the best (but I cannot think of a better one). Are you wanting to implement your tip/tilt LQG stuff in HCIPY? Maybe we can talk about this separately with others at UCSC that are interested in HCIPY controller development.