docker-nfs-server icon indicating copy to clipboard operation
docker-nfs-server copied to clipboard

feature: ARM support

Open ehough opened this issue 4 years ago • 3 comments

Currently the image is only built for x86-64. We should build an ARM-based image that can run on, for example, Raspberry Pi.

ehough avatar Jan 21 '20 18:01 ehough

subscribed :)

testautomation avatar Jan 24 '20 00:01 testautomation

Hey @ehough, I've implemented this. Just tested and it's working super fine on my raspberry: https://hub.docker.com/repository/docker/fschuindt/docker-nfs-server

Note that it's entirely based on yours and I was thinking initially to actually fork your repo and submit a PR. However, since last year, Docker for Desktop offers a nice feature called buildx. This means that from a single Dockerfile, I can from my amd64 computer, cross build it to different archs. You can read more about it here. With this in mind, I just cloned your repo and following the link, I could successfully generate a new image and pushed to my own repo with no changes in the original Dockerfile in this repo.

Let me know how you wanna handle this. Ideally, you could follow the link and add instructions on the README so people can cross build it. After this, you can start rebuilding this to your own repo on docker hub and then everyone will have multi arch support. I can help with the README, just let me know the best approach as you control the repo here.

flavioschuindt avatar Apr 19 '20 23:04 flavioschuindt

@flavioschuindt your link is not accessible without login to the docker hub. Can you please check that? You can also add a PR for the same.

pramitbiswas avatar Aug 14 '23 14:08 pramitbiswas