eu-dcc-valuesets icon indicating copy to clipboard operation
eu-dcc-valuesets copied to clipboard

country-2-codes.json: Use full name from EU publication for TW (Taiwan)

Open medicalwei opened this issue 3 years ago • 10 comments

Taiwan is listed by ISO 3166 as "Taiwan, Province of China" due to the status of Taiwan inside the UN, however this puts Taiwan directly as "a province of China" in political standpoint. As EU-DCC format is also issued from Taiwan government as well as admitting EU-DCC format from EU countries (and others adopting EU-DCC format), I would like to suggest changing it to Taiwan.

Therefore, according to List of countries, territories and currencies from EU Interinstitutional Style Guide, the full name of TW is Taiwan. Is it possible to adopt this standard over ISO 3166?

medicalwei avatar Jan 18 '22 07:01 medicalwei

@kruzikh @skounis What would be the EU's official stance on this?

dslmeinte avatar Jan 26 '22 17:01 dslmeinte

Official EU stance could be be expressed only by EU itself :-) Let's put this on the agenda of the SGS, maybe through Konstantin?

kruzikh avatar Jan 27 '22 09:01 kruzikh

Official EU stance could be expressed only by EU itself :-) Let's put this on the agenda of the SGS, maybe through Konstantin?

Agree; we need to bring/raise this in one of our forthcomming calls.

skounis avatar Jan 27 '22 09:01 skounis

FWIW: technically, the change would be trivial, and essentially have 0 impact, because the display value of the country 2-codes is not used in any code that's actively produced and maintained by the eHN. That might be different for the reference implementations of the wallet and verifier apps by T-Systems, though.

dslmeinte avatar Jan 27 '22 09:01 dslmeinte

@dslmeinte How is the country list maintained? I would guess it is generated by a list coming from ISO. If this is the case, and we decide to so, an exception in the process should be added.

skounis avatar Jan 27 '22 18:01 skounis

@skounis It's maintained in essentially the same way as the other value sets (except for test-manf.json which is included non-authoritatively here), so updates come from the Semantic Group in the form of updates to the guidelines document. We've made a couple of updates for Kosovo (XK) in the past. I'm guessing the initial contents was indeed copied verbatim from the ISO, as the Wikipedia page also list Taiwan as “province of China”.

dslmeinte avatar Jan 28 '22 07:01 dslmeinte

The original country codes value set was originally generated from FHIR vlaue set using following code:

curl http://hl7.org/fhir/R4/valueset-iso3166-1-2.json | jq '.compose.include[0].system as $system | .meta.lastUpdated[0:10] as $version| reduce .compose.include[0].concept[] as $i ({}; .[$i.code] = { "display": $i.display, "lang": "en", "active": true, "system": $system, "version": "" })| {"valueSetId": "country-2-codes", "valueSetDate":$version, "valueSetValues": .}' > ~/dev/GitHub/ehn-dgc-schema/valuesets/country-2-codes.json

Since then it is maintained manually.

kruzikh avatar Jan 28 '22 08:01 kruzikh

@kruzikh @skounis has anything happened to this?

ryanbnl avatar May 24 '22 11:05 ryanbnl

No change as far s I know. Nobody rised this issue on SGS.

kruzikh avatar May 24 '22 13:05 kruzikh

@kruzikh @ryanbnl Let's put it in the agenda for the next IOT meeting.

skounis avatar Jun 08 '22 05:06 skounis

Closing this as no changes are being made given the unclear future of the DCC. If the outlook changes it can be re-opened.

ryanbnl avatar Feb 16 '23 13:02 ryanbnl