eu-dcc-schema icon indicating copy to clipboard operation
eu-dcc-schema copied to clipboard

Improve description of "nam" field

Open benlaurie opened this issue 3 years ago • 9 comments

https://github.com/ehn-dcc-development/ehn-dcc-schema/blob/a603410d760fefc9073931c8c807759d9714c136/DCC.schema.json#L44 does not match https://github.com/ehn-dcc-development/ehn-dcc-schema/blob/release/1.3.0/DCC.Core.Types.schema.json.

benlaurie avatar Dec 12 '21 15:12 benlaurie

What's the mismatch?

dslmeinte avatar Dec 13 '21 07:12 dslmeinte

@benlaurie As with the other issue you raised: thanks for being so precise, and sorry about the short answer.

Taking the files from the latest release (1.3.1), then the nam property defined here is a reference to the person_name definition here. I don't understand just yet how that leads to a mismatch, but I'm happy to learn, as the devil is always in the details - certainly with interoperability.

dslmeinte avatar Dec 13 '21 10:12 dslmeinte

Ah. I foolishly thought that the description was meaningful. Clearly person_name is not "Person name: Surname(s), forename(s) - in that order", it is structured data that does not even have to include forenames.

So instead the bug is "person_name/description is incorrect".

benlaurie avatar Dec 13 '21 12:12 benlaurie

Also, if 1.3.1 is the current release, why is 1.3.0 the default?

benlaurie avatar Dec 13 '21 12:12 benlaurie

So instead the bug is "person_name/description is incorrect".

Ah, I now see your point! What would you like as a better description? (For starting an iteration.)

Also, if 1.3.1 is the current release, why is 1.3.0 the default?

1.3.1 should indeed be the default: I'll get back to you on that.

dslmeinte avatar Dec 13 '21 13:12 dslmeinte

Well, it should probably say its a structure defining a person's name. Also, since some of the fields refer to a "standardised name" it would be helpful to know what standard that is.

benlaurie avatar Dec 13 '21 13:12 benlaurie

Well, it should probably say its a structure defining a person's name. Also, since some of the fields refer to a "standardised name" it would be helpful to know what standard that is.

Agree with both. I took the liberty of changing the issue's title, and we'll pick this up.

dslmeinte avatar Dec 13 '21 13:12 dslmeinte

Well, it should probably say its a structure defining a person's name. Also, since some of the fields refer to a "standardised name" it would be helpful to know what standard that is.

According to https://ec.europa.eu/health/sites/health/files/ehealth/docs/covid-certificate_json_specification_en.pdf the standard (for nam/fnt in this case) is

Surname(s) of the holder transliterated using the same convention as the one used in the holder’s machine readable travel documents (such as the rules defined in ICAO Doc 9303 Part 3).

Xiphoseer avatar Dec 23 '21 23:12 Xiphoseer

@benlaurie @Xiphoseer @ryanbnl What do you think of the following for person_name's description?:

The person's name consisting at least of a separate standardised surname, or a standardised forename, or both - with standardisation done according to the rules defined in ICAO Doc 9303 Part 3

dslmeinte avatar May 19 '22 14:05 dslmeinte