Eric Haynes

Results 60 comments of Eric Haynes

Hrmm, this doesn't work in a monorepo. :( It relies on `currentPackagePath`, which searches for the directory where both a `package.json` and a `node_modules/jest` dir exist. While this is correct...

No, this should work for standard projects, so still improved from before the merge. `findConfigPath` just needs separate search logic to allow for nested `package.json` files that aren't necessarily peers...

How about #270 This changes `JestRunnerConfig#findConfigPath` to check for a jest config in any `package.json` during the same upwards traversal as it uses for the other file types. However, the...

Heh, fair enough. Anyhow, I tested my PR in a regular repo and a monorepo in a handful of scenarios with `npm`, and it seems ok. I have not tried...

Was the PR just closed due to inactivity? This has been inconsistent with the `cache-manager#Cache` interface all along, and the fix simply follows the pattern of the others...

"a lot of packages" are all by the same guy who insists, despite overwhelming evidence to the contrary, that projects no longer need to export commonjs. We'd all be better...

I don't insist on it, but it's the topic of this issue, and I think it's a worthwhile goal. Libraries should be as accommodating as possible, not attempt to force...

Definitely second this. This might have been overlooked because the starter project and examples have everything nested in projects, so I assume that could be a workaround for the time...

https://github.com/LeetCode-OpenSource/vscode-leetcode#%EF%B8%8F-attention-%EF%B8%8F--workaround-to-login-to-leetcode-endpoint It's actually the [comment above the one linked](https://github.com/LeetCode-OpenSource/vscode-leetcode/issues/478#issuecomment-559346357) that shows the steps. The cookie won't look like the image, but just copy the entire cookie value and paste it...

Admittedly, I don't know how much complexity this is under the hood, but as a language feature, it would be particularly nice if it could be used to alias the...