Etienne Hardy

icon indicating an email [email protected]

icon company AppDirect icon location Montreal, Canada

Results 28 comments of Etienne Hardy

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

@srinivasankavitha I have refreshed the PR from latest master branch, please have a look at your convenience. As I had mentioned, I'm not too well versed in Kotlin, so my...

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Hello, I refreshed the branch from last master. Is there anything else needed to move this forward? Let me know.

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Any updates that could be shared?

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Sounds good @kilink. About your comment about using Spring's `PropertyAccessorFactory` and the like, the funny thing is that my initial PR used just that. See the very [first](https://github.com/Netflix/dgs-framework/pull/1094#issuecomment-1149238749) comment, there...

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Very nice @kilink ! Will look updating this PR shortly.

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

@kilink I have updated the implementation following your recent changes in `DefaultInputObjectMapper`. I have moved back to leveraging Spring's `PropertyAccessor`. I believe this is the simplest implementation. Please have a...

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Thanks for the feedback @kilink! I have addressed comments and updated the PR. Would it be possible to have another look?

Composition performance

Thanks for the reply @sachindshinde. It didn't occur to me that memory could affect composition performance. I have plenty on my Mac compared to what we have allocated on our...