Etienne Hardy comments

Results 28 comments of


                                            Etienne Hardy

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Thanks @berngp for the feedback! Here are my thoughts about your questions: 1. Had a look at [DataBinder](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/validation/DataBinder.html). Under the hood, it uses the same `ConfigurablePropertyAccessor` (of which `BeanWrapper` is...

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

I like the idea of a benchmark, let's get actual numbers, will look into that. Also, I have started working on an alternate version of `Accessor` that would not rely...

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Hello @berngp , just a quick update on progress. I have managed to rework the implementation of `Accessor` from my previous PR to use raw Java reflection, for the most...

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Hey @berngp , I found how to deal with the situation I described above. It seems that in class hierarchies, not all `Method` instances are equal. `Method` instances in base...

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

@berngp Here's this 3rd [alternate version](https://github.com/Netflix/dgs-framework/commit/2fdd932d65820ae11b501e43fd2886ee0410f80c) that I alluded to in my previous comment.

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Hello @berngp , have you had the time to review the different alternatives? Let me know which one, if any, would be the preferred one and if any changes are...

Adding the ability to call input object setter methods if they exist, falling back to direct field access.

Hello @berngp , did you get a chance to look into this? Anything I could help further with?

Moving to GraphQL Federation V2

> what would that change mean for the license? I believe in v2, Apollo changes their license from MIT, would that mean that this library is also no longer MIT?...

Moving to GraphQL Federation V2

> dependency that has custom licenses / limitations, then we can cause a legal incident where someone builds commercial platform based on MIT license promise. Needs some kind of a...

Moving to GraphQL Federation V2

There are use cases where Federation v1 should have raised errors but did not, and now Federation v2 properly detects them. We had such an issue in one of our...