Eduardo Gulias Davis

Results 42 comments of Eduardo Gulias Davis

Hello @torbenfischer As you can see in https://github.com/egulias/EmailValidator/blob/2.1.x/tests/EmailValidator/Validation/RFCValidationTest.php#L243 , that is the expected behaviour. The email is valid, albeit with warnings for a rare option where it might work (like...

Hi, can you refer to the part of the RFC that make this valid?

Hey, thanks for spoting the typo. Feel free to make a PR with the fix!

Hello @peter279k , yes, that's true. There's a first approach with https://github.com/egulias/EmailValidator/pull/277 . Once I wrap my head around which to use, I'll migrate them.

Hi @cuchac , I'm glad you have found usefull the validation. Very detailed issue, thanks. My understanding, from your words, is that this case is common enough to have an...

Hello @tyteen4a03 , you can create one and I would be more than happy to review and merge. You can do so by creating: 1. Create a comprehensive suite of...

Looks like everything above PHP7 is failing due to psalm errors.

Hi @lptn , thanks for the heads up. I have had no time to check this one. I will review it shortly. I'll ping you if anything else is needed.

Hello @astehlik , Depends on the version of the library you are using. V2.x should mark it as valid since email RFCs are more open in the chars allowed in...

Hi @astehlik , looks like you have found a bug. Yes, should be false. I belive it will be related to encoding. Could you provide the UTF-8 code for it?...