ci: Add tests for PHP 8.4
https://github.com/vimeo/psalm/pull/10928#issuecomment-2495941226 will be available "the next week."
(I can't unapprove now)
Hi @Chris53897 thanks for your PR. I have fixed the checks so please update with the latest code to have the checks pass. Also, I believe that many deps are still not there for PHP8.4 but please double check. Thanks!
Looks like at least psalm version needs to be bumped up.
i rebased now. Yes, we still ned to wait for vimeo
Thanks! Will wait for them then.
This will look awful... but I can't find where to re-run the checks!
You can just close and reopen this PR. CI will run again
Coverage summary from Codacy
See diff coverage on Codacy
| Coverage variation | Diff coverage |
|---|---|
| Report missing for dcf8f79c410bb3906c915136369465bebead5990[^1] | :white_check_mark: ∅ |
Coverage variation details
| Coverable lines | Covered lines | Coverage | |
|---|---|---|---|
| Common ancestor commit (dcf8f79c410bb3906c915136369465bebead5990) | Report Missing | Report Missing | Report Missing |
| Head commit (ca3a4761be59ec8a6c09c12437cf38fbac6306fc) | 716 | 657 | 91.76% |
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
| Coverable lines | Covered lines | Diff coverage | |
|---|---|---|---|
| Pull request (#390) | 0 | 0 | ∅ (not applicable) |
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
See your quality gate settings Change summary preferences
Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.
"Just" 200 Errors from upgrading psalm. Should i create a baseline and ignore them?
I guess we should fix them? I agree with final and have mixed feelings with override, which are basically the two things generating the 200 errors.
@egulias Should i add the Override Attribute?