browser-id3-writer icon indicating copy to clipboard operation
browser-id3-writer copied to clipboard

Published 20 hours ago • verified publisher icon egoroof

Chapter support?

Open rexxars opened this issue 6 years ago • 8 comments

Would be great to have chapters supported. Any idea how hard that would be to add support for?

rexxars avatar Nov 22 '17 17:11 rexxars

I've got a WIP implementation of chapter support on my fork:

https://github.com/mattbasta/browser-id3-writer/commit/ea3fa5a2fbda5eb42ea1a981aaf4eb975570bc2b

mattbasta avatar Dec 03 '17 18:12 mattbasta

Oh sweet! Any plans on sending a PR for that?

rexxars avatar Dec 03 '17 18:12 rexxars

I'm going to be testing it from my fork for a while. There's also a lot of cleanup needed to bring it up to the standards for the rest of the app, and I haven't written any tests yet.

mattbasta avatar Dec 03 '17 18:12 mattbasta

I've been starting to add CHAP support, but you've implemented CTOC as well, @mattbasta, awesome! Since this is more complete I would rather help fix this up rather than keep working on my version. What can I do to help? (Should we take this to your fork?)

BrianMitchL avatar Dec 10 '17 05:12 BrianMitchL

Happy to collaborate and go over PRs (or add someone as a collaborator on my fork), but I won't have a huge amount of time to write code for this in the coming weeks. My fork was mainly to scratch an urgent itch for one of my users. Getting that back upstream would be great, but it's not my top priority at the moment.

mattbasta avatar Dec 10 '17 18:12 mattbasta

I'd love to have this upstream! I'll try to find some time in the coming weeks to start taking a look.

BrianMitchL avatar Dec 11 '17 01:12 BrianMitchL

any update on chapter support? was just looking to include this in my app.

sull avatar Oct 29 '18 17:10 sull

Any news regarding chapter support.

Chapters have become extremely common, and jsmediatags is great for reading them but writing is a different matter altogether.

We have a platform where we get the mp3 files with chapters and a placeholder for a sponsor, which hasn't been recorded yet at the time the file is stored. We wanted to add the sponsor and readjust all chapters and chapter art accordingly.

The math itself and the mp3 edition is simple enough, but rearranging the chapters is actually an incredible pain as of now.

It would be ideal to be able to get the whole tag bundle in a json, modify the timestamps from the sponsor marker onwards and reapply them to the modified audio file.

eduo avatar May 04 '21 21:05 eduo