rrdf
rrdf copied to clipboard
egonw
Define a class for the Jena model
- Defines the S4 class "triplestore", inheriting the existing java object class jobjRef.
- Also adds basic roxygen literate documentation.
Before I pull this in, can you tell me how the .Rd files are autogenerated from the inline documentation? Is that done automatically by "R CMD build"? If some command is needed, can you explain that in the README?
Good point, sorry. Several ways, easiest is to use the document()
function in the devtools package. You'll find much more detail on
@hadley's devtools GitHub page or the Roxygen2 vignette. Sorry for the
brevity, traveling now.
Carl Boettiger http://carlboettiger.info
sent from mobile device; my apologies for any terseness or typos On Dec 23, 2013 8:14 PM, "Egon Willighagen" [email protected] wrote:
The class patch is pulled in.
— Reply to this email directly or view it on GitHubhttps://github.com/egonw/rrdf/pull/23#issuecomment-31109901 .
Carl, I had applied your patch but reverted it in master, because it was causing regressions. I will look into that. You can verify issues with R CMD check rrdf_x.y.z.tar.gz ...
@egonw Thanks for the note and sorry about the error, i should have run check before sending the patch. I just missed a spot where I didn't coerce the triplestore class back to a jobjRef class before passing it to .jcall. (Actually looks like my patch forgot to commit the file triplestore.R providing the class definition). Very sorry about that.
I've fixed this in my fork and merged in your recent changes. My fork now passes R CMD check --as-cran cleanly. Again my apologies for not catching this the first time around.