CorpseReborn icon indicating copy to clipboard operation
CorpseReborn copied to clipboard

1.15 Support Discussion

Open eirikh1996 opened this issue 5 years ago • 38 comments

Hello. When will this plugin be updated to 1.15?

eirikh1996 avatar Dec 19 '19 17:12 eirikh1996

I am not sure sorry. College, Family, and YouTube are talking up pretty much all of my time currently. I didn't even know 1.15 was released 😳

egold555 avatar Dec 23 '19 01:12 egold555

Considering it supports 1.14.3 then it should be a quick update to 1.15.1 to allow us to still use the plugin :) It gives compatibility errors when loading it on a 1.15.1 server so I wonder if the main issue is really just that it lists what versions it is compatible with and you'd just need to add version support for a few higher versions? Please let us know @egold555 Thanks,

GoldenRatioMan

GoldenRatioMan avatar Jan 18 '20 23:01 GoldenRatioMan

Considering it supports 1.14.3 then it should be a quick update to 1.15.1 to allow us to still use the plugin :) It gives compatibility errors when loading it on a 1.15.1 server so I wonder if the main issue is really just that it lists what versions it is compatible with and you'd just need to add version support for a few higher versions? Please let us know @egold555 Thanks,

GoldenRatioMan

Hi. Not super sure, I have not had time to look into it. I hopefully would assume so. 1.14.3 is so buggy though, I am worried about updating to a major version without addressing the massive amount of 1.14.3 related issues I have received. Ill see if I have time to look into it tonight. I may be able to push out a beta version for 1.15 and let people test it and report back, because I just do not have a lot of time with college to test all the possible cases for bugs.

egold555 avatar Jan 19 '20 01:01 egold555

I have it somewhat working, the corpse isn't laying down because the bed isn't being placed in the world, but so far it seems stable with the latest 1.15.

egold555 avatar Jan 19 '20 01:01 egold555

I started a check list here #90

egold555 avatar Jan 19 '20 02:01 egold555

Awesome Eric. Appreciate it.

GoldenRatioMan avatar Jan 20 '20 13:01 GoldenRatioMan

Can we download it to test?

GoldenRatioMan avatar Jan 20 '20 13:01 GoldenRatioMan

I could see if I can get a build up but it is not stable what so ever. I am strongly debaiting on moving each version to a different project or something. The code is super cluttered because of how many versions I am supporting, and my IDE is starting to get confused with org.bukkit inports overlapping eachother.

egold555 avatar Jan 21 '20 23:01 egold555

I am pushing everything to here https://github.com/egold555/CorpseReborn/tree/1.15beta if you wish to attempt to compile it yourself.

Super sorry for the late reply, been busy with school :|

egold555 avatar Jan 21 '20 23:01 egold555

Got a list of dependencies?

GoldenRatioMan avatar Jan 24 '20 11:01 GoldenRatioMan

For 1.15 its just every main spigot release from 1.7.10 - 1.15. Ill upload the latest jar I have built here for 1.15, keep in mind it still does not work, and spits out loads of errors. CorpseReborn Beta 1.15.jar.zip

Github was being fussy that I needed to upload a zip, so the jar is in the zip 🤔

egold555 avatar Jan 24 '20 18:01 egold555

Any updates?

GoldenRatioMan avatar Feb 11 '20 11:02 GoldenRatioMan

Any updates?

I ask the same

eirikh1996 avatar Mar 23 '20 23:03 eirikh1996

No sorry. Haven't been focused on CR :| I will get to it hopefully soon!!!

egold555 avatar Mar 24 '20 05:03 egold555

Anymore progress on a final 1.15 release or a new beta?

eirikh1996 avatar Apr 16 '20 14:04 eirikh1996

Sadly no. I am drowning in homework now that all of my classes are online due to COVID-19.

No clue when I am going to have time to continue updating as of now.

egold555 avatar Apr 16 '20 16:04 egold555

Darklom avatar Apr 23 '20 22:04 Darklom

Considering it supports 1.14.3 then it should be a quick update to 1.15.1 to allow us to still use the plugin :) It gives compatibility errors when loading it on a 1.15.1 server so I wonder if the main issue is really just that it lists what versions it is compatible with and you'd just need to add version support for a few higher versions? Please let us know @egold555 Thanks, GoldenRatioMan

Hi. Not super sure, I have not had time to look into it. I hopefully would assume so. 1.14.3 is so buggy though, I am worried about updating to a major version without addressing the massive amount of 1.14.3 related issues I have received. Ill see if I have time to look into it tonight. I may be able to push out a beta version for 1.15 and let people test it and report back, because I just do not have a lot of time with college to test all the possible cases for bugs.

I wouldn't worry about 1.14.3 it was not a good version to begin with, it was plagued with problems and mainly lag. That is my 2 cents anyways ;)

anemul avatar May 12 '20 03:05 anemul

Alright well small update. I have been trying to port this for 3 hours now and I should be studying for exams. All I got working was fixing a lot of null pointers, but the fake players still don't sleep, and now they broadcast advancements in that, and beds get duplicated.

The NPC's try to sleep, and for like a frame they look like their sleeping, but then they just go standing again. I don't fully get why though.

idk I need to break this into small pieces or something because I just don't understand what has changed in these updates.

egold555 avatar May 14 '20 06:05 egold555

One last update before I head to bed. I think I got the player to sleep server side. The bed data says its occupied by a player, but the animation client side still isnt occurring.

Also now the fake players show up as glitchy entries in the tab list.

I think I am getting further? At this point I really don't know guys.

egold555 avatar May 14 '20 07:05 egold555

Your school work is more important, thanks for working on this. I'm sure the answers will come to you.

anemul avatar May 14 '20 13:05 anemul

We appreciate you egold!

Darklom avatar May 14 '20 21:05 Darklom

image I got some good news :)

Ill see if I can get a bit more bugs squashed, and potentially release a beta version tonight or tomorrow

egold555 avatar May 15 '20 01:05 egold555

Yay! Thanks for working on this. I use this plugin pretty religiously for my game.

kNoAPP avatar May 15 '20 19:05 kNoAPP

Please report any issues in this thread 😃

I have done some testing for 1.15 with the following server versions:

  • Spigot: git-Spigot-2f5d615-d07a78b
  • Paper Spigot: #284 bb4002d

What debug mode does:

  • Outputs a lot more console data
  • Makes the cows glow
  • Not something you should use on a production server what so ever

I recommend wiping your config file and letting it regenerate. I have not tested loading old corpses in 1.15.

Please please please make backups of your worlds, and of your corpse.yml files if you care about them. Everything should be stable, but this is a beta version and there most likely are still issues

Here is the checklist for what still needs to get done, and any currently replicate-able bugs: https://github.com/egold555/CorpseReborn/issues/90

GitHub will only let me upload the jars inside of ZIP files, so just extract the zip files. CorpseReborn 1.15 Beta.jar.zip CorpseReborn 1.15 Beta - Debug Mode.jar.zip

As with everything, sorry this took me so long, I am almost done with school, and starting to get back into Bukkit development.

Stay safe out there my dudes

egold555 avatar May 15 '20 19:05 egold555

Hi, I tried running your beta with papermc build 284 but for me the corpses are standing up. Are there additional things I have to take into account?

codingvincee avatar Jun 03 '20 13:06 codingvincee

Hi, I tried running your beta with papermc build 284 but for me the corpses are standing up. Are there additional things I have to take into account?

Yes I agree with this. The body does stand up straight 80% of the time.

lochbui avatar Jun 06 '20 02:06 lochbui

Please report any issues in this thread 😃

I have done some testing for 1.15 with the following server versions:

  • Spigot: git-Spigot-2f5d615-d07a78b
  • Paper Spigot: #284 bb4002d

What debug mode does:

  • Outputs a lot more console data
  • Makes the cows glow
  • Not something you should use on a production server what so ever

I recommend wiping your config file and letting it regenerate. I have not tested loading old corpses in 1.15.

Please please please make backups of your worlds, and of your corpse.yml files if you care about them. Everything should be stable, but this is a beta version and there most likely are still issues

Here is the checklist for what still needs to get done, and any currently replicate-able bugs: #90

GitHub will only let me upload the jars inside of ZIP files, so just extract the zip files. CorpseReborn 1.15 Beta.jar.zip CorpseReborn 1.15 Beta - Debug Mode.jar.zip

As with everything, sorry this took me so long, I am almost done with school, and starting to get back into Bukkit development.

Stay safe out there my dudes

Please fix the corpse standing up visual issue.

lochbui avatar Jun 06 '20 02:06 lochbui

I will look into it when I can. Only had it happen to me once or twice. Is i happening every time for you? If not, how do you get it to occur?

egold555 avatar Jun 08 '20 17:06 egold555

I will look into it when I can. Only had it happen to me once or twice. Is i happening every time for you? If not, how do you get it to occur?

It happens, now, almost all the time. Sometimes the bodies go lay down for a few seconds, but then they stand up. Could it possibly have to do with respawning?

Here is a list of the plugins I'm using, maybe you know of some existing issues: Plugins (31): Arcade, BedWars1058, BungeeTabListPlus, Citizens, CMI, CMIPaperLib, CoreProtect, CorpseReborn, CrazyCrates, DeluxeCommands, DeluxeMenus, DeluxeTags*, DiscordSRV, HeadDatabase*, HolographicDisplays, LuckPerms, Mineclaps, MobDisabler, MurderMystery, OldCombatMechanics, PlaceholderAPI, PlugMan, Skywars, Skywars-Extension*, spark, TNTRun_reloaded, VoidWorld*, WDLCompanion*, WorldEdit, WorldGuard, WorldGuardExtraFlags

codingvincee avatar Jun 08 '20 18:06 codingvincee