vue-slim-tabs
vue-slim-tabs copied to clipboard
Fix onSelect usage
This PR is fixing all aspects of #40:
- emit a
select
custom event so that we can use JSX withonSelect
prop, - keep the legacy way of passing the
onSelect
function prop as a callback (for retro-compatibility), - avoid multiple executions of the
onSelect
callback (and "select" event) when clicking on the same tab again, - add an example using JSX, with
onSelect
event handling, - add an example of
onSelect
callback in existing example which use template.
I hope you'll approve this soon!
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/egoist/vue-slim-tabs/8CMri4YFQGDxN5h2C1nyDuv5x82Y
✅ Preview: https://vue-slim-tabs-git-fork-polosson-fix-jsx-usage-egoist.vercel.app
Hi @egoist !
Any chance to have this little PR reviewed and merged? I really need this improvement...
Or, can you please tell us if this lib is dead?
Thanks a lot, by the way.
Cheers!