bili icon indicating copy to clipboard operation
bili copied to clipboard

[question] Adding rollup-plugin-vue now requires inline-bundle of rollup-plugin-commonjs when generating esm?

Open xaksis opened this issue 4 years ago • 4 comments

Adding rollup-plugin-vue now requires including rollup-plugin-commonjs: https://github.com/vuejs/rollup-plugin-vue#usage

This adds an inline dependency in esm files: import __vue_normalize__ from 'vue-runtime-helpers/dist/normalize-component.js';

does this mean we'll have to use --bundleNodeModules?

xaksis avatar Jul 09 '19 10:07 xaksis

Same question.

jofftiquez avatar Aug 29 '19 16:08 jofftiquez

I get the same issue

LeCoupa avatar Nov 04 '19 13:11 LeCoupa

This is related to rollup-plugin-vue rather Bili, But using --bundle-node-modules seems to fix this for now. Just consider that this will include all of your imports in bundle, not only this one.

hosein2398 avatar Nov 12 '19 22:11 hosein2398

In the rollup-plugin-vue docs, I could not find any information regarding this. The author explains it here though: https://github.com/vuejs/rollup-plugin-vue/issues/308#issuecomment-557139789

Given that bili wants to be “ridiculously easy”, I think it should provide sensible defaults here.

bodograumann avatar Oct 20 '20 14:10 bodograumann