ledger-autosync icon indicating copy to clipboard operation
ledger-autosync copied to clipboard

Don't access keyring when not needed

Open DamienCassou opened this issue 6 years ago • 6 comments

When using ledger-autosync to read an existing ofx file, I don't expect ledger-autosync to access my keyring and ask me to unlock it. This annoys me because I don't use Gnome keyring and I don't want any application to use it and ask me to unlock it.

DamienCassou avatar Jul 31 '18 06:07 DamienCassou

Thanks for the report! I haven't been using gnome keyring with ledger-autosync so I haven't seen this. Did you need to configure it explicitly, or was it configured when you ran ofxclient?

egh avatar Aug 01 '18 04:08 egh

Did you need to configure it explicitly

I haven't configured anything.

or was it configured when you ran ofxclient?

I don't use ofxclient. I get my ofx files through boobank.

DamienCassou avatar Aug 01 '18 05:08 DamienCassou

Great, I'll try to replicate this behavior locally.

(As an aside, I didn't know boobank could fetch OFX files. I'll have to check it out.)

egh avatar Aug 01 '18 14:08 egh

@DamienCassou @egh this seems to be a result of ofxclient. I opened an issue there: https://github.com/captin411/ofxclient/issues/78

My workaround is to comment out the import keyring and keyring.get_password() lines from ofxclient/cli.py, and also set KEYRING_AVAILABLE to False always.

Hope this helps!

rcurtin avatar Sep 08 '19 03:09 rcurtin

Thank you, Ryan!

egh avatar Sep 08 '19 06:09 egh

For anybody still having this problem (it's still there in ofxclient), this still solves the problem as of 1/2024 except that the offending lines to comment out have moved to ofxclient/config.py

jlesieutre avatar Jan 31 '24 12:01 jlesieutre