eggyal

Results 35 comments of eggyal

Maybe https://github.com/cucumber/microcuke (an official, minimal—only 500 SLOC, JS reference implementation) could be useful?

FWIW, I see that #1144 was linked in the context of Cucumber being for E2E testing. That's not really correct, at all. Cucumber is merely an engine for running Gherkin...

With https://github.com/rustwasm/wasm-bindgen/pull/1737, it's possible to do: ```rust #[wasm_bindgen(prototype=web_sys::HtmlElement)] struct MyCustomElement {} #[wasm_bindgen] impl MyCustomElement { #[wasm_bindgen(constructor)] fn new() -> WasmType { instantiate! { MyCustomElement{} } } } // ... web_sys::window()...

Given that there is already some degree of implementation for this in [`src/disabled`](https://github.com/hyperium/headers/tree/master/src/disabled) (and taking note of https://github.com/hyperium/headers/pull/67#issuecomment-596712858 together with related commit a514a37), what is the thinking for moving this...

In terms of external API, perhaps expose a trait: ```rust pub trait QualityItem { fn quality(&self) -> u16; fn item(&self) -> &T; } ``` Which might have a generic implementation...

Actually, the problem is (slightly) more serious than I first thought. Some commands, especially DDL ones, can accept object identifiers that don't exist. For example: ``` php $_GET['colname'] = "\x8c`...

@seanmonstar I'm happy to take a look at this, but I'm not sure about the proposed API. In particular: > * Add a `pusher(req: &mut http::Request) -> hyper::Result` that can...

[Effective Rust, Item 24](https://lurklurk.org/effective-rust/re-export.html) recommends at very least re-exporting any types that appear in your public API. I personally go a step further and reexport the entire crate in which...

You may also find [this discussion](https://github.com/rust-lang/api-guidelines/discussions/176) in the official "API guidelines" repo relevant/useful.