ESTabBarController icon indicating copy to clipboard operation
ESTabBarController copied to clipboard

delegate to ESTabBarController, when user shouldSelect function will run 2 times

Open aemoe opened this issue 7 years ago • 9 comments
trafficstars

let tabController:ESTabBarController = ESTabBarController()
tabController.delegate = self
func tabBarController(_ tabBarController: UITabBarController, shouldSelect viewController: UIViewController) -> Bool {
        print("running")
        return true
    }

aemoe avatar Oct 17 '18 05:10 aemoe

Any problems?

eggswift avatar Oct 31 '18 11:10 eggswift

@eggswift
使用delegate时 shouldSelect 方法执行了2次 我看了下源代码 看到你绑定调用了2次这个事件

aemoe avatar Oct 31 '18 11:10 aemoe

sa

@eggswift 使用delegate时 shouldSelect 方法执行了2次 我看了下源代码 看到你绑定调用了2次这个事件

we fould the same problems

DeforeChen avatar Nov 22 '18 09:11 DeforeChen

Hi,

yes, same issue here. What we are seeing is that when a tab bar item is selected, the shouldSelect delegate is called twice. Is there any way to get around this?

Thanks for your work! We use it since 2 years without any major problems.

cheers

ThreadPitt avatar May 07 '19 07:05 ThreadPitt

Ohh let me check this.

eggswift avatar May 14 '19 03:05 eggswift

Ohh let me check this.

I also found the same problems, I just started using it recently.

czjwarrior avatar May 14 '19 06:05 czjwarrior

@aemoe 看到你绑定调用了2次这个事件 ??? 可以让我看一下哪块的代码么? 或者你可以尝试提交一个MR,成为开发成员

eggswift avatar Jun 02 '19 05:06 eggswift

屏幕快照 2019-08-23 上午11 54 32 屏幕快照 2019-08-23 上午11 54 40

遇到同样的问题@eggswift,问题大概出现在这边。

LiuSky avatar Aug 23 '19 03:08 LiuSky

@eggswift any updates to this? Have the same problem. ShouldSelect running twice because of highlightAction in ESTabBarItemContainer

denandreychuk avatar May 05 '20 19:05 denandreychuk